Add --save-records option to pg_waldump #572
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hlinnaka
reviewed
Feb 5, 2025
Contributor
hlinnaka
left a comment
hlinnaka
left a comment
There was a problem hiding this comment.
Please add a brief comment explaining the file format
Author
Done |
hlinnaka
reviewed
Feb 10, 2025
hlinnaka
approved these changes
Feb 10, 2025
problame
reviewed
Feb 10, 2025
problame
left a comment
problame
left a comment
There was a problem hiding this comment.
Can't judge the C code, but, as someone who has been commanding the incident during which this was developed: it was a helpful tool.
Would be nice to have a tiny test for this feature so it doesn't bit-rot.
Ideally we'd test that this tool can be used instead of get_values_reconstruct_data in the pageserver / that they always return both results.
Realistically, let's just have a tiny test that points the tool to some Safekeeper WAL and verify that
- the exit status is 0 when invoked for some page / LSN range
- when piping generated wal stream into walredo process, we get the same page image that we get from the pageserver (use this testing API to get the page image that pageserver returns)
knizhnik
force-pushed
the
pg_waldump_save_records
branch
from
d7514ab to
e5fcb13
Compare
Co-authored-by: Heikki Linnakangas <heikki@neon.tech>
github-merge-queue bot
pushed a commit
to neondatabase/neon
that referenced
this pull request
Feb 10, 2025
## Problem Make it possible to dump WAL records in format recognised by walredo process. Intended usage: ``` pg_waldump -R 1663/5/16396 -B 771727 000000010000000100000034 --save-records=/tmp/walredo.records postgres --wal-redo < /tmp/walredo.records > /tmp/page.img ``` ## Summary of changes Related Postgres PRs: neondatabase/postgres#575 neondatabase/postgres#572 --------- Co-authored-by: Konstantin Knizhnik <knizhnik@neon.tech>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it possible to dump WAL records in format recognised by walredo process.
Intended usage: