Move CheckPointBuffers to PreCheckPointGuts to save FSM/VM pages on normal shutdown #614
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knizhnik
force-pushed
the
move_checkpoint_buffers_to_precheckpointguts_v15
branch
from
b0c4159 to
aeb292e
Compare
hlinnaka
approved these changes
Apr 7, 2025
github-merge-queue bot
pushed a commit
to neondatabase/neon
that referenced
this pull request
Apr 7, 2025
## Problem See https://neondb.slack.com/archives/C03QLRH7PPD/p1743746717119179 We wallow FSM/VM pages when they are written to disk to persist them in PS. But it is not happen during shutdown checkpoint, because writing to WAL during checkpoint cause Postgres panic. ## Summary of changes Move `CheckPointBuffers` call to `PreCheckPointGuts` Postgres PRs: neondatabase/postgres#615 neondatabase/postgres#614 neondatabase/postgres#613 neondatabase/postgres#612 --------- Co-authored-by: Konstantin Knizhnik <knizhnik@neon.tech>
Bodobolero
pushed a commit
to neondatabase/neon
that referenced
this pull request
Apr 9, 2025
## Problem See https://neondb.slack.com/archives/C03QLRH7PPD/p1743746717119179 We wallow FSM/VM pages when they are written to disk to persist them in PS. But it is not happen during shutdown checkpoint, because writing to WAL during checkpoint cause Postgres panic. ## Summary of changes Move `CheckPointBuffers` call to `PreCheckPointGuts` Postgres PRs: neondatabase/postgres#615 neondatabase/postgres#614 neondatabase/postgres#613 neondatabase/postgres#612 --------- Co-authored-by: Konstantin Knizhnik <knizhnik@neon.tech>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.