backport: Use normal install program to install server headers. #660
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a backport of PostgreSQL commit c0a1d76 to REL_14_STABLE. Our top-level Makefile in the neon repository depends on "make install" not modifying the mtimes on the headers, if there have been no changes to them. Otherwise, the `postgres_ffi` rust crate and all the other components that depends on it get rebuilt every time you run `make`.
tristan957
approved these changes
Jun 20, 2025
github-merge-queue bot
pushed a commit
to neondatabase/neon
that referenced
this pull request
Jun 21, 2025
Every time you run `make`, it runs `make install` on all the PostgreSQL sources, which copies the header files. That in turn triggers a rebuild of the `postgres_ffi` crate, and everything that depends on it. We had worked around this earlier (see #2458), by passing a custom INSTALL script to the Postgres makefiles, which refrains from updating the modification timestamp on headers when they have not been changed, but the v14 makefile didn't obey INSTALL for the header files. Backporting c0a1d76 to v14 fixes that. This backports upstream PostgreSQL commit c0a1d76 to v14. Corresponding PR in the 'postgres' repo: neondatabase/postgres#660
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PostgreSQL commit c0a1d76 to REL_14_STABLE. Our top-level Makefile in the neon repository depends on "make install" not modifying the mtimes on the headers, if there have been no changes to them. Otherwise, the
postgres_ffirust crate and all the other components that depends on it get rebuilt every time you runmake.