Add sql error code hook

[dimitri]

No description provided.

[MMeent]

Couldn't we use elog.h's emit_log_hook to collect error codes?

I'm fairly sure this isn't always called, and so this will skip e.g. XX000/ERRCODE_INTERNAL_ERROR.

While skipping those may be OK for the current use case, it's likely to cause issues down the line.

[tristan957]

Please remove the pull request number in the commit message.

[dimitri]

Ooops. On a series of rebasing branches for CI to run, I realized after the fact that this branch had received other commits. Now I can't fetch them from github anymore. We've lost some changes.

[HaoyuHuang]

Couldn't we use elog.h's emit_log_hook to collect error codes?

I'm fairly sure this isn't always called, and so this will skip e.g. XX000/ERRCODE_INTERNAL_ERROR.

While skipping those may be OK for the current use case, it's likely to cause issues down the line.

I checked and for this corruption errors, this errcode function is always called. Let's merge this? Suhas PR depends on this change. @thesuhas

[MMeent]

I checked and for this corruption errors, this errcode function is always called. Let's merge this? Suhas PR depends on this change.

As shared in his PR and as I mentioned above, while that PR does depend on this PR (because it uses this new hook) it should instead use the existing emit_log_hook, which provides more log coverage than this hook and keeps our diff with upstream more manageable.

[HaoyuHuang]

I checked and for this corruption errors, this errcode function is always called. Let's merge this? Suhas PR depends on this change.

As shared in his PR and as I mentioned above, while that PR does depend on this PR (because it uses this new hook) it should instead use the existing emit_log_hook, which provides more log coverage than this hook and keeps our diff with upstream more manageable.

Yes. Let's merge this in and get rid of this hook once we get into one repo. WDYT?

[dimitri]

From discussion, we can close this one and use emit_log_hook in the calling code.