Move extension_is_visible_hook to extension.h/extension.c (PG 17)#936
Merged
dcw-data merged 1 commit intoREL_17_STABLE_neonfrom Mar 21, 2026
Merged
Conversation
dcw-data
force-pushed
the
dcw/extension-is-visible-hook-v17
branch
from
fee174c to
985ea79
Compare
HaoyuHuang
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Move
extension_is_visible_hookdeclaration fromfmgr.h/fmgr.ctocommands/extension.h/extension.cwhere it conceptually belongs.Follow-up to the initial hook addition — the hook is about extension catalog filtering, not function manager operations, so it belongs alongside the other extension management declarations.
Changes
src/include/fmgr.h— Remove hook typedef and extern (moved)src/backend/utils/fmgr/fmgr.c— Remove hook variable init (moved)src/include/commands/extension.h— Add hook typedef and externsrc/backend/commands/extension.c— Add hook variable init alongside other globals