Correct type of types option to CustomTypesConfig
#115
+28
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@jawj I would be happy to update this PR for the new refactor if you would like to accept it? Context/reasoning in the linked issue: #110 (comment) Small beans really but there is currently a type cast in a fix I wrote for the Prisma Neon adapter that can be removed to tidy things up from a type safety perspective if this is accepted. |
Collaborator
|
Ditto, thanks, this looks good: will gladly merge if updated. |
Collaborator
|
Rolling this into a new PR ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: #110 (comment)
I've also updated the example in CONFIG.md, although the way pg's types are written seem to require userland use of
anyon the format parameter andas typeof PgTypes.getTypeParsercast on the custom implementation ofgetTypeParser(), which is quite displeasing 😭It may be preferable to keep the current example for simplicity (as it doesn't require these userland typescript workarounds), potentially with a warning about global scope pollution. 🤷♂️