Skip to content

#243 Database lock fixes #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Nov 9, 2021
Merged

#243 Database lock fixes #261

merged 16 commits into from
Nov 9, 2021

Conversation

@otselnik
Copy link
Contributor

@otselnik otselnik commented Nov 2, 2021 •
edited
Loading

Changes:

  • new class SQLDict for SqliteDictreplacement,
  • migrate LogDB from sqlite3 to psycopg2,
  • merge '265_indexer_fixes' for less indexer errors(#265 indexer fixes #266).

@otselnik otselnik requested a review from s-medvedev November 2, 2021 20:17
@otselnik otselnik changed the title №243 Вatabase lock fixes #243 Вatabase lock fixes Nov 2, 2021
vakond added a commit that referenced this pull request Nov 3, 2021
@vakond
#261 restrict write instruction (#215)
2aa4072 
* Use keccak_256 instead of shake_256 (261-restrict-write-instruction)

* Use WriteHolder (15=0x0F) instead of Write (0) (261-restrict-write-instruction)

* WriteHolder index: 15 => 16 (261-restrict-write-instruction)

* WriteHolder index: 16 => 17 (261-restrict-write-instruction)

* WriteHolder index: 17 => 18 (261-restrict-write-instruction)

* WriteHolder instruction creates bigger trx due to seed (261-restrict-write-instruction)

* WriteHolder instruction creates bigger trx due to seed (261-restrict-write-instruction)

* Comment unneeded logging (261-restrict-write-instruction)

* bugfix (261-restrict-write-instruction)

* Refactor WriteHolder from seed to nonce (261-restrict-write-instruction)

* Exclude signer pubkey from seed generation (261-restrict-write-instruction)

* Remove dead code (261-restrict-write-instruction)
@otselnik otselnik changed the title #243 Вatabase lock fixes #243 Database lock fixes Nov 3, 2021
@otselnik otselnik self-assigned this Nov 3, 2021
s-medvedev
s-medvedev reviewed Nov 4, 2021
View reviewed changes
Copy link
Contributor

@s-medvedev s-medvedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let rework with PostgreSQL.

@otselnik otselnik requested a review from s-medvedev November 8, 2021 11:07
s-medvedev
s-medvedev previously approved these changes Nov 9, 2021
View reviewed changes
@s-medvedev s-medvedev merged commit cf6b250 into develop Nov 9, 2021
@s-medvedev s-medvedev deleted the 243_database_lock branch November 9, 2021 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@s-medvedev s-medvedev s-medvedev approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@otselnik otselnik

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@otselnik @s-medvedev