BUGFIX: Throw helpful exception when collection property has missing element type#2139
Merged
BUGFIX: Throw helpful exception when collection property has missing element type#2139
Conversation
bwaidelich
requested changes
Sep 24, 2020
albe
commented
Sep 24, 2020
bwaidelich
approved these changes
Sep 24, 2020
Member
bwaidelich
left a comment
bwaidelich
left a comment
There was a problem hiding this comment.
Thanks for clarifying
+1 by reading
Contributor
Author
|
Apparently, the exception will not be thrown when an empty collection is submitted. Which is a bit... shaggy. Adding a check to the ObjectConverter is probably more sane, but also not as easy (we have three versions of where to check the type - constructor arguments, setter argument, property). Or one could make the point, that it is only really a problem when actually submitting values, because then property mapping will fail, so this is fine as is 🤷♂️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #978