Closed
Conversation
nezaniel
requested review from
grebaldi,
markusguenther,
mhsdesign and
skurfuerst
dlubitz
approved these changes
Mar 27, 2025
Contributor
dlubitz
left a comment
dlubitz
left a comment
There was a problem hiding this comment.
Looks good by reading. Thank you
Contributor
|
We should do that for 8.3 first and upmerge. |
Member
|
the code changed probably some to 8.3 so merging this first makes upmerges hard ... i guess do it indeed first for 8.3 ... lets do it all in batch together at the sprint to be fast going;) |
Member
Author
|
agreed, here we go: |
Member
Author
|
Made obsolete by #3935 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes PHP8.4 deprecation warnings
What I did
I removed implicit nullability