-
Notifications
You must be signed in to change notification settings - Fork 127
build/dist: modernize pyproject.toml #600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
pyproject.toml
Outdated
|
|
||
| [project] | ||
| name = "pynvim" | ||
| version = "0.6.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does python have a standard tool for auto-incrementing this, similar to npm version ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the comments.
In this case, bump-my-version is the better option. It handles auto-incrementing the version and also fixes the issue with the hard-coded download URL by updating it automatically.
It adds a couple of new commands, like bump-my-version patch for a small fix or bump-my-version minor for a new feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just wanted to ask for your guidance on documentation: where would be the best place to add notes about using this tool/commands? docs/development.rst?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a step here:
Line 135 in c59abe4
| Release |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of modifying the existing numbered steps, I've created a new subsection titled 'Releasing with bump-my-version' directly below the original 'Release' section.
My reasoning for this was to preserve the historical context of the manual release steps, while clearly introducing the new, automated bump-my-version process as a distinct and streamlined alternative. This way, both methods are documented, and the benefits of automation are highlighted without disrupting the established manual procedure.
The new section provides clear instructions on how to use bump-my-version to increment versions, create commits, and tag releases, which should simplify future release management.
Please let me know if this approach works for you.
| [build-system] | ||
| requires = ["setuptools"] | ||
| build-backend = "setuptools.build_meta" | ||
| requires = ["setuptools", "wheel"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is wheel required?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Including wheel is a best practice that ensures your project can be built into the modern, faster-installing wheel format, while not strictly necessary to build a basic source distribution, it's a key part of the modern Python packaging ecosystem.
|
Thanks! This is helpful. |
This pull request modernizes the project's packaging configuration by fully adopting
pyproject.toml, in accordance with PEP 621.Key changes include:
setup.pyto the[project]table inpyproject.toml.This centralizes the project's configuration, making it easier to manage and align with modern Python packaging standards.
Fixes #598