Open
Conversation
GitHub URL patterns now correctly parse URLs with explicit ports like https://github.com:8443/owner/repo.git, which previously fell through to BasePlatform and lost owner/name extraction. Changes: - GitHub HTTPS/SSH/git regex patterns now capture port separately from domain - Added port_colon format helper in result.py for URL reconstruction - GitHub FORMATS updated to preserve ports across protocol rewrites - Tests: 11 new parse cases, 9 rewrite cases, component rewrite with port Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Member
|
@turian Hi, thanks for opening this pr! In order to make the CI pass may I ask you to:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
parse()returns incomplete metadata for GitHub URLs with explicit ports (e.g.https://github.com:8443/owner/repo.git) — the port causes domain mismatch, so the URL falls through to BasePlatform and losesowner/nameextractionport_colonformat helper inresult.pyfor correct URL reconstruction (:8443when port is set, empty otherwise)url2ssh,url2https,url2git)Minimal reproduction
Test plan
https://github.com:8443/Org/Repo.git→ github, port=8443git://github.com:9418/Org/Repo.git→ github, port=9418ssh://git@github.com:2222/Org/Repo.git→ github, port=2222git@github.com:Org/Repo.git→ github, port=""https://user:token@github.com:8443/Org/Repo.gitgithub.com:abc) don't match GitHub🤖 Generated with Claude Code