refactor: make CSV export default, consolidate instruction files#3
Conversation
- Remove --csv flag (CSV export always enabled for CLI binary) - Update help text to clarify CSV is default output format - Delete outdated .github/instructions/rust-project.instructions.md - AGENTS.md is now single source of truth for project instructions BREAKING CHANGE: --csv flag removed, CSV export is now always enabled
📝 WalkthroughWalkthroughThe PR deletes a GitHub instructions markdown file and updates the CLI in Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🧰 Additional context used📓 Path-based instructions (4)src/main.rs📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Files:
**/*.rs📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Files:
src/**/*.rs📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Files:
{src,tests,benches,examples}/**/*.rs📄 CodeRabbit inference engine (.github/instructions/rust-project.instructions.md)
Files:
🧠 Learnings (1)📓 Common learnings🔇 Additional comments (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.github/instructions/rust-project.instructions.md(0 hunks)src/main.rs(4 hunks)
💤 Files with no reviewable changes (1)
- .github/instructions/rust-project.instructions.md
🧰 Additional context used
📓 Path-based instructions (4)
src/main.rs
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Maintain the Rust application entry point at src/main.rs
Files:
src/main.rs
**/*.rs
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
**/*.rs: Do not remove or modify comments unless the related Rust code is changed; only add comments that explain code functionality (no AI instructional comments)
Never embed or call external binaries from Rust code
Files:
src/main.rs
src/**/*.rs
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Only commit Rust source files under src when committing code changes (no blanket git add)
Files:
src/main.rs
{src,tests,benches,examples}/**/*.rs
📄 CodeRabbit inference engine (.github/instructions/rust-project.instructions.md)
{src,tests,benches,examples}/**/*.rs: Do not remove or modify comments unless the related Rust code is changed
Only add comments that explain code functionality; do not add AI instructional comments
Never embed or call external binaries from Rust code
Files:
src/main.rs
🧠 Learnings (1)
📓 Common learnings
Learnt from: nerdCopter
PR: nerdCopter/bbl_parser#2
File: LICENSE_COMMERCIAL:1-4
Timestamp: 2025-08-29T19:52:05.099Z
Learning: nerdCopter prefers to avoid publishing personal information in license files for privacy and security reasons, as they are an individual maintainer rather than a company.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Test (windows-latest)
- GitHub Check: Test (macos-latest)
🔇 Additional comments (3)
src/main.rs (3)
264-264: LGTM! Clear documentation of the new default behavior.The updated command description accurately reflects that CSV export is now the default format, with GPX and JSON as optional additions.
281-281: LGTM! Appropriately generalized help text.The help text now correctly describes the directory as being for all output files (CSV, GPX, JSON) rather than just CSV files.
330-336: LGTM! CSV export now unconditionally enabled.The hardcoded
csv: truecorrectly implements the breaking change described in the PR. The retention of theExportOptions.csvfield (rather than removing it entirely) suggests this codebase may be used as a library where the field could still be useful for API consumers.
BREAKING CHANGE: --csv flag removed, CSV export is now always enabled
Summary by CodeRabbit
New Features
Documentation
Chores