perf(core): reuse Sets in notification loop instead of allocating per flush#108
Merged
Merged
Conversation
… flush (#64) Replace new Set() allocation on every flush iteration with a double-buffer pattern using two pre-allocated Sets (flushing/queued). Eliminates GC pressure from short-lived Set allocations under cascading-update workloads. Benchmarked: ~38% improvement on derive chain (depth 10, 100k iterations).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #64
Summary
new Set()allocation on every flush iteration with a double-buffer pattern using two pre-allocated Sets (flushing/queued).clear()it so it's ready for reuse on the next iterationBenchmark
Derive chain depth=10, 100k iterations per batch:
new Setper flush)~38% improvement.
Test plan