Skip to content

fix(ci): update check-action-versions v2 caller to composite form#136

Closed
nerdalytics wants to merge 3 commits intotrunkfrom
fix/check-actions-composite-caller
Closed

fix(ci): update check-action-versions v2 caller to composite form#136
nerdalytics wants to merge 3 commits intotrunkfrom
fix/check-actions-composite-caller

Conversation

@nerdalytics
Copy link
Copy Markdown
Owner

The upstream action at nerdalytics/check-action-versions@v1 was converted from a reusable workflow to a composite action (see upstream PR #2). This updates beacon's caller to match.

Previously, on the first manual dispatch after PR #135 merged, the v2 pilot workflow failed with invalid refspec because the action tried to check out its own scripts using ${{ github.workflow_ref }}, which inside a reusable workflow resolves to the caller's workflow ref rather than the callee's. Composite actions have ${{ github.action_path }} and avoid the issue entirely.

Caller API changes:

  • jobs.check.uses: removed; replaced with runs-on: ubuntu-latest + steps: with explicit actions/checkout and uses: nerdalytics/check-action-versions@v1
  • secrets: block removed; secrets now ride in via with: as gh-pat, signing-key, signing-passphrase (still passed as ${{ secrets.X }} for masking)

After merge, manually dispatch to validate end-to-end (Phase 2 of the rollout plan).

The upstream action at nerdalytics/check-action-versions@v1 was converted
from a reusable workflow to a composite action to fix an architectural
bug: reusable workflows cannot reference their own files because
${{ github.workflow_ref }} resolves to the caller's ref, not the
callee's. Composite actions have ${{ github.action_path }} which is the
canonical pattern for shipping scripts alongside an action.

Caller syntax change required:
- jobs.check.uses: <…workflow@v1> -> jobs.check.steps[] with own checkout
  plus 'uses: nerdalytics/check-action-versions@v1'
- 'secrets:' block removed; GH_PAT/SIGNING_KEY/SIGNING_PASSPHRASE now ride
  in via 'with:' as gh-pat/signing-key/signing-passphrase (still passed as
  ${{ secrets.X }} for masking).
Comment thread .github/workflows/check-action-versions-v2.yml Fixed
Beacon's supply-chain policy rejects tag-ref actions ('must be pinned to
a full-length commit SHA'). Pin to the v1 commit SHA with the tag as
comment, matching the convention across all other uses: in this repo.
Upstream v1 retagged to 3c702505 (fix PR #3 removing template syntax
from input descriptions that blocked action-manifest loading).
@nerdalytics
Copy link
Copy Markdown
Owner Author

Superseded by #139 — branch update-github-actions-v2 carries the full commit series including this PR's three caller-fix commits plus the automation's action-update commit. Squash-merging #139 brings the whole delta to trunk in one shot.

nerdalytics added a commit that referenced this pull request Apr 20, 2026
Squash-merges branch `update-github-actions-v2`, which contains:
- 3 caller fixes from the now-closed PR #136 (composite-action conversion, SHA-pin, retag SHA bump to include v1 description fix)
- 1 automation commit bumping `actions/setup-node` (v6.3.0 → v6.4.0) and `actions/cache` (v5.0.4 → v5.0.5)

Closes #137.
nerdalytics added a commit that referenced this pull request Apr 20, 2026
…tion (#140)

Deletes the in-repo workflow and 9 action-checker scripts (scan-actions,
resolve-latest, compare-actions, generate-report, manage-issue,
apply-updates, commit-changes, manage-pr, close-if-current), replaced by
a call to the shared composite action at
nerdalytics/check-action-versions@3c70250.

Pilot verified in PR #135/#136/#139 — both outdated and up-to-date paths
behave identically to the pre-cutover workflow.

Preserves branch-name 'automation/update-github-actions' (override, not
default) so the new workflow recognizes and replaces PR #134 instead of
orphaning it. Default issue-title matches existing issue #133 for
auto-inherit behavior.

Preserves .github/scripts/check-version.sh and check-version-sync.sh
(npm/jsr version-diffing scripts, unrelated).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants