Fix action checker: arithmetic exit code and missing labels#31
Merged
Conversation
- With set -e, ((OUTDATED_COUNT++)) exits with code 1 when the counter is 0 because the expression evaluates to 0 (false). Added || true. - Create security and dependencies labels if they don't exist before creating the issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two bugs in the action version checker workflow.
Bug 1: Arithmetic exit code
With
set -e,((OUTDATED_COUNT++))exits with code 1 whenOUTDATED_COUNTis 0 because the expression evaluates to 0 (false).Fix: Added
|| trueto prevent script termination.Bug 2: Missing labels
The workflow failed with
could not add label: 'security' not foundwhen the repository doesn't have the required labels.Fix: Create
securityanddependencieslabels before creating the issue (using--forceso it's idempotent).