fix(scripts): remove non-functional update-performance-docs script#91
Merged
Merged
Conversation
The script imported `BenchmarkResult` and `runAllBenchmarks` from `./benchmark.ts`, but neither export exists. It could never run. No PERFORMANCE.md or metrics/ directory was ever created by it.
test:core referenced `tests/*-core.test.ts` — no files match that pattern. test:integration referenced `tests/state-*.test.ts` and `tests/batch-integration.test.ts` — neither exists.
…node --test Remove 11 test:unit:* scripts and test:behavior — they were thin wrappers around `node --test tests/<file>.test.ts`. Contributors can call that directly. Added a note to CONTRIBUTING.md showing the pattern.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #75
Summary
scripts/update-performance-docs.ts— it importedBenchmarkResultandrunAllBenchmarksfrom./benchmark.ts, but neither export exists. The script was never functional.update-performance-docsnpm script frompackage.jsonscripts/README.mdto remove the entry and fix link numberingtest:corescript — globtests/*-core.test.tsmatches zero filestest:integrationscript —tests/state-*.test.tsandtests/batch-integration.test.tsdon't existTest plan
npx tsc --noEmitpassesnpm test— 117/117 pass