Closed
Conversation
added 3 commits
July 11, 2021 12:13
…nloading selected after size-getting
Owner
|
The intended way the sideloader should download games is, show users the game size, and only if users accepts it then proceed to download |
Author
And I have not altered this in any way. There was a bug, that if you select some game A, click the download button, then immediately select some game B, the accept the size dialog it will start downloading game B instead of game A. This PR fixes that. |
SamHoque
added a commit
to SamHoque/androidsideloader
that referenced
this pull request
Jul 17, 2021
- Recreated branch nerdunit#61 created by @dkgitdev since the branch had some merge conflicts, that was too long to resolve.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add: message for one game downloading.
Fix: now the Download button downloads the games it got size for, not just selected ones