This repository was archived by the owner on Apr 6, 2026. It is now read-only.
feat(reminder): rewrite module with smart loop, calendar scheduling, and timezone support#199
Merged
Conversation
Introduce parse_duration() backed by pytimeparse2 for human-friendly duration strings (e.g. '2h30m', '1d12h', '90s'). Bare integers are treated as minutes for backward compatibility. Enforces a 60-second minimum. Includes full test suite (12 tests). Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
…olumns Co-Authored-By: Claude <noreply@anthropic.com>
…lumns Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
The 'duration' parameter was ambiguous (delay vs runtime?) and 'start' created confusing interactions with 'duration' depending on repeat mode. Renamed to 'in' (reads naturally: "remind in 2h30m") using @app_commands.rename, and removed 'start' entirely since /reminder schedule already covers calendar-based timing. Co-Authored-By: Claude <noreply@anthropic.com>
Add new utility modules (duration, schedule) to the utilities section and document gotchas discovered during the rewrite: plans gitignored, app_commands.callback testing pattern, rename decorator, and dialect-aware Alembic migrations. Co-Authored-By: Claude <noreply@anthropic.com>
karaktaka
force-pushed
the
feat/reminder-rewrite
branch
from
9a917e6 to
8dfa025
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #175
WHERE NextFire <= NOW()and adjusts sleep based on the next due reminder/reminder create in:<delay> message [channel] [repeat]for interval-based reminders,/reminder schedulefor calendar-based (daily/weekly/monthly) with timezone autocompleteNextFiretimestamps,ScheduleTypecolumn (once/interval/daily/weekly/monthly), per-reminderTimezone(IANA), with Alembic migration preserving existing dataparse_duration()for human-friendly input (2h30m,1d12h,1w),compute_next_fire()for DST-aware calendar recomputationNextFireif it's in the pastdurationparam toin(reads naturally), removed confusingstartparamTest plan
🤖 Generated with Claude Code