This repository was archived by the owner on Apr 6, 2026. It is now read-only.
feat(application): multi-role support for manager and reviewer roles#256
Merged
Conversation
…le-role columns Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
… junction table Co-Authored-By: Claude <noreply@anthropic.com>
…viewerrole commands Co-Authored-By: Claude <noreply@anthropic.com>
…er/reviewer roles Co-Authored-By: Claude <noreply@anthropic.com>
…er/reviewer roles Replace the old single-role ApplicationGuildConfig lookup with a query against ApplicationGuildRole so all configured manager and reviewer roles are pinged when a new submission is posted to the review channel. Also update TestHasManagePermission tests to use ApplicationGuildRole instead of the removed ApplicationGuildConfig.ManagerRoleId/ReviewerRoleId columns. Co-Authored-By: Claude <noreply@anthropic.com>
…-role support (add/remove/clear/list) Co-Authored-By: Claude <noreply@anthropic.com>
When the bot lacks permissions in the review channel, the error message was incorrectly referencing `channel` (the apply channel), which can be None in settings commands and would raise AttributeError. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ApplicationGuildRole(GuildId, RoleId, RoleType)replaces the singleManagerRoleId/ReviewerRoleIdcolumns onApplicationGuildConfig, allowing guilds to assign multiple Discord roles to each typecheck_application_permission,check_override_permission) rewritten to query all configured roles and useany()intersectionmanageroleandreviewerrolenow haveadd <role>,remove <role>,clear, andlistsubcommands (replacing the old singleset/removepair)Test plan
/application managerole add @Role— adds role, idempotent on repeat/application managerole remove @Role— removes specific role; shows error if not configured/application managerole clear— removes all manager roles/application managerole list— shows embed with all configured rolesreviewerrolealembic upgrade headon an existing DB migrates single-role data correctlycreate_all) produces correct schema without migration needed🤖 Generated with Claude Code