Skip to content
This repository was archived by the owner on Apr 6, 2026. It is now read-only.

feat(application): open thread on review embed and ping roles inside thread#258

Merged
karaktaka merged 7 commits into
mainfrom
feat/application-review-thread
Feb 27, 2026
Merged

feat(application): open thread on review embed and ping roles inside thread#258
karaktaka merged 7 commits into
mainfrom
feat/application-review-thread

Conversation

@karaktaka
Copy link
Copy Markdown
Contributor

@karaktaka karaktaka commented Feb 26, 2026

Summary

  • Review embed is now posted to the review channel without inline role pings
  • A public thread is immediately opened on the embed (named after the applicant)
  • Role mentions (manager, reviewer, and non-managed admin roles) are sent inside the thread instead
  • Managed (bot/integration) roles with administrator permissions are filtered out of the ping to avoid mentioning bot accounts

Test Plan

  • Submit an application and verify the review embed has no inline mentions
  • Verify a thread is created immediately on the embed, named after the applicant
  • Verify role pings appear as a message inside the thread
  • Verify bot/integration roles with admin perms are not mentioned
  • Verify thread creation failure is handled gracefully (ReviewMessageId still saved)

🤖 Generated with Claude Code

karaktaka and others added 7 commits February 26, 2026 23:47
@karaktaka @claude
feat(application): add review_thread_name locale key
10d9234 
Co-Authored-By: Claude <noreply@anthropic.com>
@karaktaka @claude
test(application): update role-mention tests for thread-based pings
b8b51a1 
Co-Authored-By: Claude <noreply@anthropic.com>
@karaktaka @claude
test(application): add managed-role filter and thread-failure tests
dcbd7cc 
Co-Authored-By: Claude <noreply@anthropic.com>
@karaktaka @claude
test(application): wire thread mock into mock_review_channel fixture
5129724 
Co-Authored-By: Claude <noreply@anthropic.com>
@karaktaka @claude
feat(application): open thread on review embed and ping roles inside …
fdc1372 
…thread

Post the review embed with no inline role pings, immediately create a
public thread on the embed message, and send role mentions inside the
thread. Also filter managed (bot/integration) roles from the admin
permission sweep.

Co-Authored-By: Claude <noreply@anthropic.com>
@karaktaka @claude
test(application): clean up stale docstrings and add missing create_t…
fd81670 
…hread assertion

Co-Authored-By: Claude <noreply@anthropic.com>
@karaktaka @claude
style: ruff format conversations/application.py
170459e 
Co-Authored-By: Claude <noreply@anthropic.com>
@karaktaka karaktaka merged commit 6fdf087 into main Feb 27, 2026
6 checks passed
@karaktaka karaktaka deleted the feat/application-review-thread branch February 27, 2026 08:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@karaktaka