This repository was archived by the owner on Apr 6, 2026. It is now read-only.
refactor(application): migrate TextInput.label to discord.ui.Label wrapper#264
Merged
Merged
Conversation
…apper (#261) discord.py 2.6 deprecated the TextInput.label property setter in favor of the Component v2 Label wrapper. Migrate all 10 modal classes across views/application.py and application.py to instance-level TextInput fields wrapped with discord.ui.Label(text=..., component=...). Also fix PyCharm inspection findings: add @staticmethod to two wow.py methods that don't use self, and make finish_board_create/finish_board_edit public since they're called from _BoardDescriptionModal outside the class. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
views/application.pyandapplication.pyfrom deprecatedTextInput.labelproperty setter to discord.py 2.6discord.ui.Label(text=..., component=...)wrapper (closes #261)_localize_fieldhelper to accept modal and use Label wrapper instead of setting.labeldirectly@staticmethodto_parse_role_idsand_auto_match_rolesinwow.py(PyCharm inspection fix)_finish_board_create/_finish_board_editto public methods since they're called cross-class from_BoardDescriptionModaltest_application_view.pyto match renamed instance attributesTest plan
uv run ruff check— all checks passeduv run ruff format --check— 98 files already formatteduv run python -m pytest tests/modules/test_application_view.py -v— 93/93 passeduv run python -m pytest— 944/944 passed🤖 Generated with Claude Code