Skip to content
This repository was archived by the owner on Apr 6, 2026. It is now read-only.

fix(bot): call load_strings() before registering persistent views#358

Merged
karaktaka merged 1 commit into
mainfrom
fix/load-strings-before-persistent-views
Mar 18, 2026
Merged

fix(bot): call load_strings() before registering persistent views#358
karaktaka merged 1 commit into
mainfrom
fix/load-strings-before-persistent-views

Conversation

@karaktaka
Copy link
Copy Markdown
Contributor

Summary

  • ApplicationReviewView.__init__ calls get_string() to set button labels, but _strings was empty at that point
  • load_strings() was running after add_view(), so the localization cache was never populated when views were constructed
  • Moved load_strings() before the persistent view registration block — fixes the KeyError: Missing localization key: application.review.btn_vote crash on startup

Test plan

  • Bot starts without the Missing localization key: application.review.btn_vote error
  • Application review buttons render with correct labels

🤖 Generated with Claude Code

ApplicationReviewView.__init__ calls get_string() to set button labels,
but _strings was empty because load_strings() ran after add_view(). Move
load_strings() before the persistent view registration block.

Co-Authored-By: Claude <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 18, 2026

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 66c4698f-4226-4aaf-936b-983c3e9a50cd

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@karaktaka karaktaka merged commit cdcd380 into main Mar 18, 2026
11 checks passed
@karaktaka karaktaka deleted the fix/load-strings-before-persistent-views branch March 18, 2026 18:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant