fix: wallet infinite loop in fake out selection#47
Merged
Conversation
Port of monero-project/monero#8794. The gamma picker and the caller disagreed on the number of available rct outputs by one block, which could cause an infinite loop when the picker had exhausted all valid outputs from previous blocks but the caller expected one more.
ngeojiajun
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
num_outscalculation, which could cause an infinite loop during decoy selectionget_num_rct_outs()getter togamma_pickerso the caller uses the picker's own count instead of computing it independently