Conversation
Calling print_prompt() from refresh callbacks (on_money_received, on_money_spent, on_get_password) corrupts readline/terminal state. During auto-refresh, these callbacks run in a background thread and call print_prompt() which manipulates readline from a non-main thread while the main thread is in rl_callback_read_char() — this is undefined behavior for readline and corrupts terminal state. During manual refresh, readline is already paused via PAUSE_READLINE() so calling print_prompt() is also incorrect. The message_writer() destructor already handles readline suspension via RAII, so messages are displayed correctly without print_prompt(). The main thread's readline loop naturally redisplays the prompt. Fixes #37
ngeojiajun
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
print_prompt()calls fromon_money_received,on_money_spent, andon_get_passwordrefresh callbacksprint_prompt()manipulates readline from a non-main thread — this is undefined behavior for readline and corrupts terminal state (echo disabled, input interpreted as commands)PAUSE_READLINE()soprint_prompt()is also incorrectmessage_writer()destructor already handles readline suspension via RAII, so messages display correctly withoutprint_prompt(). The main thread's readline loop naturally redisplays the prompt.Fixes #37