feat: default to 1 mining thread on Android for autodetect#63
Merged
Conversation
On mobile devices, autodetecting and ramping up to the optimal thread count can cause thermal and battery issues. When mining is started with thread count 0 (autodetect) on Android, default to 1 thread instead of running the progressive autodetection. Users can still set a higher thread count manually. Closes #62
Build Artifacts
10 succeeded, 0 failed | View workflow run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Mobile devices have thermal and battery constraints that make full CPU utilization unsuitable as a default. The existing autodetect ramps threads up progressively which is fine on desktop but inappropriate for phones/tablets.
Closes #62