Conversation
There was a problem hiding this comment.
Pull request overview
This PR synchronizes Credo configuration and fixes code style issues to comply with stricter Credo checks, specifically StrictModuleLayout and Specs.
Changes:
- Enabled strict mode in Credo configuration and added
StrictModuleLayoutandSpecschecks - Updated dependencies (credo, ex_doc, makeup_erlang) to newer versions
- Reorganized module attributes to follow Credo's strict module layout conventions (moduledoc, behaviour, use, alias, require order)
- Added type specifications to test helper functions
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
.credo.exs |
Enabled strict mode and added StrictModuleLayout and Specs checks |
mix.lock |
Updated credo, ex_doc, and makeup_erlang dependencies |
lib/ssh_subsystem_fwup/fwup_port.ex |
Moved require Logger after @moduledoc per strict layout rules |
lib/ssh_subsystem_fwup.ex |
Reorganized alias and require statements after @behaviour per strict layout rules |
lib/mix/tasks/upload.ex |
Moved use Mix.Task after @moduledoc per strict layout rules |
lib/mix/tasks/firmware.gen.script.ex |
Moved use Mix.Task and module attributes after @moduledoc; replaced moduledoc interpolation with literal string |
test/ssh_subsystem_fwup_test.exs |
Added @spec annotations to test helper functions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.