Skip to content

Sync credo checks with other projects and fix#145

Merged
fhunleth merged 1 commit intomainfrom
bump-credo
Jan 28, 2026
Merged

Sync credo checks with other projects and fix#145
fhunleth merged 1 commit intomainfrom
bump-credo

Conversation

@fhunleth
Copy link
Copy Markdown
Member

No description provided.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR synchronizes Credo configuration and fixes code style issues to comply with stricter Credo checks, specifically StrictModuleLayout and Specs.

Changes:

  • Enabled strict mode in Credo configuration and added StrictModuleLayout and Specs checks
  • Updated dependencies (credo, ex_doc, makeup_erlang) to newer versions
  • Reorganized module attributes to follow Credo's strict module layout conventions (moduledoc, behaviour, use, alias, require order)
  • Added type specifications to test helper functions

Reviewed changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
.credo.exs Enabled strict mode and added StrictModuleLayout and Specs checks
mix.lock Updated credo, ex_doc, and makeup_erlang dependencies
lib/ssh_subsystem_fwup/fwup_port.ex Moved require Logger after @moduledoc per strict layout rules
lib/ssh_subsystem_fwup.ex Reorganized alias and require statements after @behaviour per strict layout rules
lib/mix/tasks/upload.ex Moved use Mix.Task after @moduledoc per strict layout rules
lib/mix/tasks/firmware.gen.script.ex Moved use Mix.Task and module attributes after @moduledoc; replaced moduledoc interpolation with literal string
test/ssh_subsystem_fwup_test.exs Added @spec annotations to test helper functions

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@fhunleth fhunleth merged commit 2eb63d6 into main Jan 28, 2026
12 of 13 checks passed
@fhunleth fhunleth deleted the bump-credo branch January 28, 2026 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants