Skip to content

fix: prevent multi times dialing kad connection to the same peer#20

Merged
quake merged 3 commits intodevelopfrom
jjyr/fix-kad-dialing
Nov 26, 2018
Merged

fix: prevent multi times dialing kad connection to the same peer#20
quake merged 3 commits intodevelopfrom
jjyr/fix-kad-dialing

Conversation

@jjyr
Copy link
Copy Markdown
Contributor

@jjyr jjyr commented Nov 22, 2018

Fixed the kad discovery problems

Comment thread network/src/discovery_service.rs Outdated
@doitian
Copy link
Copy Markdown
Member

doitian commented Nov 23, 2018

@TheWaWaR @quake any feedback?

Copy link
Copy Markdown
Member

@doitian doitian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commits c88464b and 1b41dc9 are too trivial to be included in the history. Either use Squash and merge, or rebase the PR locally.

@doitian doitian dismissed their stale review November 23, 2018 08:57

Will squash and merge when aprooved

@quake quake merged commit 01bcaf4 into develop Nov 26, 2018
@doitian doitian deleted the jjyr/fix-kad-dialing branch November 26, 2018 08:22
contrun pushed a commit to contrun/ckb that referenced this pull request Jan 23, 2024
…Add integration test to check correctly sync after restart

Add integration test to check correctly sync after restart
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants