feat: verify address according to chain type#1071
Merged
ashchan merged 4 commits intonervosnetwork:developfrom Nov 14, 2019
Keith-CY:strengthen-address-validation
Merged
feat: verify address according to chain type#1071ashchan merged 4 commits intonervosnetwork:developfrom Keith-CY:strengthen-address-validation
ashchan merged 4 commits intonervosnetwork:developfrom
Keith-CY:strengthen-address-validation
Conversation
Contributor
|
Conflicts and CI failed. |
Co-Authored-By: CL <classicalliu@gmail.com>
Keith-CY
changed the title
![nervos-bot[bot]](https://avatars.githubusercontent.com/in/22976?s=60&v=4){kind=small}
Keith-CY
changed the title
Keith-CY
changed the title
nervos-bot
bot
dismissed
their stale review
Unhold as requested by @Keith-CY.
ashchan
approved these changes
Nov 14, 2019
|
|
||
| const isAffordable = verifyTotalAmount(totalAmount, fee, balance) | ||
| const network = networks.find(n => n.id === networkID) | ||
| const isMainnet = (network && network.chain === 'ckb') || false // TODO: should be replaced after the mainnet tag is introduced |
Contributor
There was a problem hiding this comment.
Please use the mainnet tag feature which was recently merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.