[ᚬrc/v0.29.0] feat: refine the nervos dao record component#1449
Merged
Keith-CY merged 1 commit intorc/v0.29.0from Mar 9, 2020
Merged
[ᚬrc/v0.29.0] feat: refine the nervos dao record component#1449Keith-CY merged 1 commit intorc/v0.29.0from
Keith-CY merged 1 commit intorc/v0.29.0from
Conversation
Collaborator
Keith-CY
commented
Mar 6, 2020
Keith-CY
commented
- including immature time in compensation period
- ameliorate epoch estimation up to index/length
- refactor the record component for better testing in storybook
- add tests in storybook
nervos-bot
bot
changed the title
Keith-CY
force-pushed
the
refine-nervos-dao-record-component
branch
5 times, most recently
from
3b907b6 to
d76c239
Compare
1. including immature time in compensation period, which means the period is `180 * n + 4` epochs 2. ameliorate epoch estimation up to index/length In the last version a deposit at epoch 0.1 makes the withdraw epoch to 181 but now it's considered as 180.1 3. refactor the record component for better testing in storybook 4. add tests in storybook
Keith-CY
force-pushed
the
refine-nervos-dao-record-component
branch
from
d76c239 to
43d6755
Compare
classicalliu
approved these changes
Mar 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.