Merged
Conversation
Collaborator
Keith-CY
commented
Apr 17, 2022
Keith-CY
commented
- refactor epochParser with SDK
- remove unused prompt function
- fix toUint128Le function, it read wrong bytes in low digits
Keith-CY
force-pushed
the
fix-to-uint128-le
branch
from
877f547 to
6233104
Compare
1. refactor epochParser with SDK 2. remove unused prompt function 3. fix toUint128Le function, it read wrong bytes in low digits
Keith-CY
force-pushed
the
fix-to-uint128-le
branch
from
6233104 to
f372dd1
Compare
yanguoyu
reviewed
Apr 18, 2022
yanguoyu
approved these changes
Apr 18, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.