Merged
Conversation
1. fix sudt amount of creating sudt asset account, it was not set when txType is one of 'create' and 'destroy' 2. update export-history to make exported history consistent with those displayed in window
yanguoyu
reviewed
May 5, 2022
| } else { | ||
| sUDTAmount = '--' | ||
| } | ||
| if (['create', 'destroy'].includes(tx.type || '')) { |
Collaborator
Author
There was a problem hiding this comment.
Unnecessary
|| ''
tx.type could be undefined that will be blamed by tsc undefined cannot be assigned to string(string is required by arr.includes())
yanguoyu
approved these changes
May 5, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
set when txType is one of 'create' and 'destroy'
with those displayed in window
--- screenshots ---
Fix sudt amount of creating sudt asset account
Before
After
Fix exported history to be consistent with that displayed in window
Before
After
