Merged
Conversation
Keith-CY
reviewed
Jun 1, 2022
qiweiii
approved these changes
Jun 1, 2022
Keith-CY
approved these changes
Jun 1, 2022
Cedar67
approved these changes
Jun 8, 2022
Contributor
Cedar67
left a comment
Cedar67
left a comment
There was a problem hiding this comment.
The following enhances have been verified in the Windows OS.
- sign and export tx could be disabled when the password is empty
- canceling sign and export leads to an incorrect error Unable to save JSON File
- export should not dismiss the dialog directly until the user confirms to save the tx.
hd.mov
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
export tx
i. hd wallet
hd-export-tx.mov
hard-export-tx.mov
sign and export tx
i. hd wallet
hd-sign-export-tx.mov
hard-sign-export-tx.mov