feat: add address format toggle in receive tabs#2408
Merged
Conversation
Add a button next to the address in receive tabs to toggle address foramts between full version and deprecated version. The switch is designed to be neglectable because the deprecated format is discouraged. Ref: Magickbase/neuron-public-issues#22
Keith-CY
force-pushed
the
add-format-switch-in-receive-tab
branch
from
e8fa040 to
c2e42df
Compare
yanguoyu
reviewed
Jun 1, 2022
| import styles from './sUDTReceive.module.scss' | ||
|
|
||
| const { DEFAULT_SUDT_FIELDS } = CONSTANTS | ||
| const toShortAddr = (addr: string) => { |
Contributor
There was a problem hiding this comment.
This function looks almost the same as toShortAddr at Receive/index/tsx
Collaborator
Author
There was a problem hiding this comment.
I left them in component modules respectively because they are simple and will be removed eventually. Without sharing them between components makes sure no codes will be left on removing.
qiweiii
approved these changes
Jun 1, 2022
yanguoyu
approved these changes
Jun 1, 2022
yanguoyu
approved these changes
Jun 1, 2022
This was referenced Jun 9, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a button next to the address in receive tabs to toggle
address foramts between full version and deprecated version.
The switch is designed to be neglectable because the deprecated
format is discouraged.
Ref: Magickbase/neuron-public-issues#22
Screen.Recording.2022-05-31.at.21.15.40.mov