fix: Fix open create hardware wallet after open import seed.#2425
Merged
Keith-CY merged 1 commit intonervosnetwork:developfrom Jun 17, 2022
Merged
fix: Fix open create hardware wallet after open import seed.#2425Keith-CY merged 1 commit intonervosnetwork:developfrom
Keith-CY merged 1 commit intonervosnetwork:developfrom
Conversation
Keith-CY
approved these changes
Jun 17, 2022
Cedar67
approved these changes
Jun 17, 2022
Contributor
Cedar67
left a comment
There was a problem hiding this comment.
Test Results: Verified.
Verified environment: Windows OS
Test case & results:
✅ Import Seed -> Import Hardware
✅ Import Hardware -> Import Seed
✅ Import Keystore -> Import Hardware
✅ Import Hardware -> Import Keystore
✅ Import Seed -> Import Keystore
✅ Import Keystore -> Import Seed
✅ Import Seed -> Import Public key
✅ Import Keystore -> Import Public key
✅ Import Hardware -> Import Public key
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix-open-hardwallet.mov