Skip to content

fix: Adapt ledger nano s plus.#2434

Merged
Keith-CY merged 1 commit intonervosnetwork:developfrom
yanguoyu:fix-nanos-plus
Jul 5, 2022
Merged

fix: Adapt ledger nano s plus.#2434
Keith-CY merged 1 commit intonervosnetwork:developfrom
yanguoyu:fix-nanos-plus

Conversation

@yanguoyu
Copy link
Contributor

  1. If the device is adapt
nanosplus.mov
  1. If a new device does not adapt in the future, maybe you can try select other option if the APIs do not change
other-device.mov

@Keith-CY
Copy link
Collaborator

Keith-CY commented Jul 4, 2022

Just verify if other ledgers work because we just have on ledger nano s plus. Let's verify ledger nano s plus after release @Cedar67 @FrederLu

@Cedar67
Copy link
Contributor

Cedar67 commented Jul 4, 2022

Just verify if other ledgers work because we just have on ledger nano s plus. Let's verify ledger nano s plus after release @Cedar67 @FrederLu

got it.

Copy link
Contributor

@Cedar67 Cedar67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has been verified that the hardware wallet of the model Ledger Nano X works normally.

@Keith-CY Keith-CY merged commit 1587ca2 into nervosnetwork:develop Jul 5, 2022
@Keith-CY Keith-CY mentioned this pull request Jul 5, 2022
@yanguoyu yanguoyu deleted the fix-nanos-plus branch July 11, 2022 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants