Skip to content

chore: bump node from 16 to 18#2518

Merged
Keith-CY merged 7 commits intonervosnetwork:developfrom
alexsupa597:fix/bump-node-from-16-to-18
Nov 7, 2022
Merged

chore: bump node from 16 to 18#2518
Keith-CY merged 7 commits intonervosnetwork:developfrom
alexsupa597:fix/bump-node-from-16-to-18

Conversation

@alexsupa597
Copy link

What problem does this PR solve?

Bump Node.js from 16 to 18
Ref: Magickbase/neuron-public-issues#72

Check List

Test

default

Task

none

@Keith-CY
Copy link
Collaborator

Keith-CY commented Nov 4, 2022

Tests keeps failing, not sure if it's caused by the update of Node.js
Failed: https://github.com/nervosnetwork/neuron/actions/runs/3391092948/jobs/5636061603#step:9:90

@Keith-CY Keith-CY changed the title bump node from 16 to 18 chore: bump node from 16 to 18 Nov 7, 2022
@Keith-CY Keith-CY merged commit 66316cb into nervosnetwork:develop Nov 7, 2022
@alexsupa597 alexsupa597 deleted the fix/bump-node-from-16-to-18 branch November 7, 2022 13:49
@Keith-CY Keith-CY mentioned this pull request Dec 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants