Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR bumps the Node.js version and updates OS runner labels to their latest versions in various GitHub Actions workflows in order to catch runtime exceptions early.
- Update Node.js from a fixed version (20.15.1) to "latest"
- Update Ubuntu and Windows runner labels to use the "latest" versions
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/update_wallet_env.yml | Updated Node version from 20.15.1 to latest |
| .github/workflows/update_neuron_compatible.yml | Updated Node version from 20.15.1 to latest |
| .github/workflows/update_ckb_client_versions.yml | Updated Node version from 20.15.1 to latest |
| .github/workflows/unit_tests.yml | Updated Node version, typo in "latset" detected |
| .github/workflows/package_for_test.yml | Updated Node version and OS labels |
| .github/workflows/package.yml | Updated Node version and OS labels |
| .github/workflows/check_storybook.yml | Updated Node version and OS labels |
894b154 to
9f2ca2e
Compare
1. use lts node.js 2. use latest ubuntu 3. use latset windows By doing so, exceptions in the latest runtime can be handled early
9f2ca2e to
db740c1
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR bumps the Node.js version and updates the OS images in CI workflows to use the latest available environments, aiming to catch runtime exceptions earlier.
- Update Node version from 20.15.1 to lts/* across multiple workflows
- Replace fixed Ubuntu/Windows versions with ubuntu-latest and windows-latest
- Rename and broaden the Linux dependencies step to apply based on the runner's OS
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/update_wallet_env.yml | Updated Node version to lts/* |
| .github/workflows/update_neuron_compatible.yml | Updated Node version to lts/* |
| .github/workflows/update_ckb_client_versions.yml | Updated Node version to lts/* |
| .github/workflows/unit_tests.yml | Updated Node version, Ubuntu image, and Linux dependencies step |
| .github/workflows/package_for_test.yml | Updated Node version, OS images, and Linux dependencies step |
| .github/workflows/package.yml | Updated Node version, OS images, and Linux dependencies step |
| .github/workflows/check_storybook.yml | Updated Node version, OS images, and Linux dependencies step |
Comments suppressed due to low confidence (4)
.github/workflows/unit_tests.yml:46
- The condition was changed from checking for Ubuntu specifically to any Linux runner. Verify that all Linux environments used support the apt-get commands, as this might lead to issues on non-Ubuntu Linux systems.
if: runner.os == 'Linux'
.github/workflows/package_for_test.yml:134
- The if condition now applies to all Linux runners rather than only Ubuntu. Confirm that this broader scope is intentional, as the apt-get utilities may not be available on all Linux distributions.
if: runner.os == 'Linux'
.github/workflows/package.yml:92
- Ensure that using 'if: runner.os == "Linux"' covers only the intended Linux environments, as apt-get based installations may not work on all Linux distributions.
if: runner.os == 'Linux'
.github/workflows/check_storybook.yml:46
- The broad condition 'if: runner.os == "Linux"' automatically applies the Linux dependencies installation to any Linux runner. Verify that this change is intentional and that the target Linux environments support the apt-get commands used.
if: runner.os == 'Linux'
devchenyan
approved these changes
Apr 22, 2025
Collaborator
Author
yanguoyu
approved these changes
Apr 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By doing so, exceptions in the latest runtime can be handled early