Skip to content

ci: bump node and runner in ci#3346

Merged
Keith-CY merged 1 commit intodevelopfrom
bump-node-and-runner-in-ci
Apr 22, 2025
Merged

ci: bump node and runner in ci#3346
Keith-CY merged 1 commit intodevelopfrom
bump-node-and-runner-in-ci

Conversation

@Keith-CY
Copy link
Collaborator

@Keith-CY Keith-CY commented Apr 22, 2025

  1. use lts node.js
  2. use latest ubuntu
  3. use latset windows

By doing so, exceptions in the latest runtime can be handled early

@Keith-CY Keith-CY requested a review from Copilot April 22, 2025 06:32
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR bumps the Node.js version and updates OS runner labels to their latest versions in various GitHub Actions workflows in order to catch runtime exceptions early.

  • Update Node.js from a fixed version (20.15.1) to "latest"
  • Update Ubuntu and Windows runner labels to use the "latest" versions

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
.github/workflows/update_wallet_env.yml Updated Node version from 20.15.1 to latest
.github/workflows/update_neuron_compatible.yml Updated Node version from 20.15.1 to latest
.github/workflows/update_ckb_client_versions.yml Updated Node version from 20.15.1 to latest
.github/workflows/unit_tests.yml Updated Node version, typo in "latset" detected
.github/workflows/package_for_test.yml Updated Node version and OS labels
.github/workflows/package.yml Updated Node version and OS labels
.github/workflows/check_storybook.yml Updated Node version and OS labels

@Keith-CY Keith-CY force-pushed the bump-node-and-runner-in-ci branch 2 times, most recently from 894b154 to 9f2ca2e Compare April 22, 2025 06:58
1. use lts node.js
2. use latest ubuntu
3. use latset windows

By doing so, exceptions in the latest runtime can be handled early
@Keith-CY Keith-CY force-pushed the bump-node-and-runner-in-ci branch from 9f2ca2e to db740c1 Compare April 22, 2025 07:12
@Keith-CY Keith-CY marked this pull request as ready for review April 22, 2025 07:25
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR bumps the Node.js version and updates the OS images in CI workflows to use the latest available environments, aiming to catch runtime exceptions earlier.

  • Update Node version from 20.15.1 to lts/* across multiple workflows
  • Replace fixed Ubuntu/Windows versions with ubuntu-latest and windows-latest
  • Rename and broaden the Linux dependencies step to apply based on the runner's OS

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
.github/workflows/update_wallet_env.yml Updated Node version to lts/*
.github/workflows/update_neuron_compatible.yml Updated Node version to lts/*
.github/workflows/update_ckb_client_versions.yml Updated Node version to lts/*
.github/workflows/unit_tests.yml Updated Node version, Ubuntu image, and Linux dependencies step
.github/workflows/package_for_test.yml Updated Node version, OS images, and Linux dependencies step
.github/workflows/package.yml Updated Node version, OS images, and Linux dependencies step
.github/workflows/check_storybook.yml Updated Node version, OS images, and Linux dependencies step
Comments suppressed due to low confidence (4)

.github/workflows/unit_tests.yml:46

  • The condition was changed from checking for Ubuntu specifically to any Linux runner. Verify that all Linux environments used support the apt-get commands, as this might lead to issues on non-Ubuntu Linux systems.
if: runner.os == 'Linux'

.github/workflows/package_for_test.yml:134

  • The if condition now applies to all Linux runners rather than only Ubuntu. Confirm that this broader scope is intentional, as the apt-get utilities may not be available on all Linux distributions.
if: runner.os == 'Linux'

.github/workflows/package.yml:92

  • Ensure that using 'if: runner.os == "Linux"' covers only the intended Linux environments, as apt-get based installations may not work on all Linux distributions.
if: runner.os == 'Linux'

.github/workflows/check_storybook.yml:46

  • The broad condition 'if: runner.os == "Linux"' automatically applies the Linux dependencies installation to any Linux runner. Verify that this change is intentional and that the target Linux environments support the apt-get commands used.
if: runner.os == 'Linux'

@Keith-CY Keith-CY enabled auto-merge April 22, 2025 08:48
@Keith-CY
Copy link
Collaborator Author

Please have a review @yanguoyu @homura

@Keith-CY Keith-CY added this pull request to the merge queue Apr 22, 2025
Merged via the queue into develop with commit ac6e603 Apr 22, 2025
23 checks passed
@Keith-CY Keith-CY deleted the bump-node-and-runner-in-ci branch April 22, 2025 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants