-
Notifications
You must be signed in to change notification settings - Fork 15
Improve requirements #121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve requirements #121
Conversation
jakobj
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there are a lot of changes i'm not sure about. are they directly related to improving reqs? do you need them bc you remove pickle?
changes in requirements.txt look good, i like the version tagging. but what's the intention behind creating a separate directory?
|
@benelot currently the file Can the second part (after the empty line) be removed? |
|
Exactly, I separated them in order to not install all of them just for the documentation part. |
|
I think we can remove the second part from the docs requirements. I mean the following requirements The docs should run through without them. In case it does not, I can fix it afterwards again by checking why it breaks on the docs side. For the release, this will not matter. |
benelot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is exactly how I would do the requirements.txt handling. The separate folder is not necessary, but reduces the clutter of the repository base folder. From what I see in other repositories, there are still a lot of standard documents that will reside in the base folder after some years, so it is good to clean up from time to time.
Removes requirements from root dir and moves it to
requirements/Removes
dillandpathosfrom requirements. Applies associated changes tocompartmentfitter. Modifiessovtreeto not rely on lambda-functions that can only be pickled withdill.