Vectorize impedance matrix calculation for different expansion points #130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erent expansion points
…ree when the ion channel is not present at some nodes
jakobj
suggested changes
Nov 29, 2021
Contributor
jakobj
left a comment
jakobj
left a comment
There was a problem hiding this comment.
great work! 🚀
i went through the changes, but unfortunately can not check whether they are conceptually correct, so i have to rely on your judgement and the testsuite. i've added some comments that should be addressed before merging.
Co-authored-by: Jakob Jordan <1562742+jakobj@users.noreply.github.com>
Co-authored-by: Jakob Jordan <1562742+jakobj@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Runtime original 'compartmentfitter.fitModel()' call for the BAC-firing example:
>>> Elapsed time fitModel call: 128.455 sRuntime new 'compartmentfitter.fitModel()' call:
>>> Elapsed time fitModel call: 33.412 sOn a 3.1GHz Intel Core i5 with 16 GB 2133 MHz LPDDR3 memory.