fix installation for default mechanisms and modfile compilation #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakobj
suggested changes
Mar 10, 2020
Contributor
jakobj
left a comment
jakobj
left a comment
There was a problem hiding this comment.
nice work, thanks! 🎉 🎉 totally missed that before.
added a few comments that should be addressed before merging.
setup.py
Outdated
| if os.path.exists(mech_path): | ||
| shutil.rmtree(mech_path) | ||
| shutil.copytree('neat/tools/simtools/neuron/mech_storage/', mech_path) | ||
| open('neat/tools/simtools/neuron/mech/__init__.py', 'wb') |
Contributor
There was a problem hiding this comment.
is this left over from debugging? should not leave open file pointers lying around ;)
Collaborator
Author
There was a problem hiding this comment.
closed the file pointer. This is to put an init file in the mech directory so that it is copied to the install location.
jakobj
reviewed
Mar 11, 2020
jakobj
reviewed
Mar 11, 2020
Co-Authored-By: Jakob Jordan <1562742+jakobj@users.noreply.github.com>
Collaborator
Author
|
I was thinking that it might also be possilbe to import multiple .so files in neuron, so that user-defined channels could perhaps be compiled inplace and then a link to the .so file is added in the toolbox. We can merge this now and add an issue to investigate this? |
jakobj
approved these changes
Mar 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ion channel installation was not yet working properly (somehow previous builds must have been storing things). New setup.py should fix it.