-
Notifications
You must be signed in to change notification settings - Fork 2k
feat(queues): add bullmq documentation #2805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
tolgap
reviewed
Oct 1, 2023
|
Eagerly awaiting this. Recently joined a new project where devs still used |
5 tasks
|
Bump |
|
Any updates on this please? |
Co-authored-by: Tolga Paksoy <tolga@paramander.com>
Co-authored-by: Tolga Paksoy <tolga@paramander.com>
Co-authored-by: Tolga Paksoy <tolga@paramander.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Only Bull (not BullMQ) usage is documented.
Issue Number: #2353
What is the new behavior?
Both Bull and BullMQ are documented.
Does this PR introduce a breaking change?
Other information
WIP. I have a few ToDo's to complete before it's ready for merge. However, I would appreciate feedback on the changes before investing more time in it.
Specifically, I lost interest in the change halfway through because I realized that BullMQ drops some important features I need. While there are workarounds, I decided to keep using Bull myself.
The features are:
On the other side, the only new feature is Parent/Child Dependencies, which I personally don't feel a need for. If you want to pay for the pro version there are more features, like:
Observables, Group Rate Limit, Group Support and Batches Support. With that in consideration, I would say that currently the only benefit of BullMQ is that it's easier to replace with BullMQ-Pro if you ever need it.
What do you think? Should BullMQ be covered the way it's proposed in this PR? Should it be after Bull? Should it just be mentioned and direct people to https://docs.bullmq.io/guide/nestjs if it's something they find interesting?