docs(microservices): Update ip address:port for a gRPC Docker server #2987
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Actually
https://github.com/youngkiu/nest/blob/7f00840c074ba5a5f233f73ef6c8456115abd7c1/packages/microservices/constants.ts#L11, I wanted to suggest modifying
GRPC_DEFAULT_URL,Since it was clearly stated as Default in the document, I thought there was an intention to do this.
So, I suggest modifying the example in the document.
In the case of servers, it is often built and used as a docker image.
0.0.0.0:50051seems more appropriate as an example thanlocalhost:50051.In particular, in the case of gRPC in the target group of the AWS load balancer,
since the success code of the health check is 12(UNIMPLEMENTED),
I hope that if the example is
0.0.0.0:50051it will further reduce confusion.