Skip to content

Conversation

@esahin90
Copy link
Contributor

@esahin90 esahin90 commented Jul 4, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Docs
  • Other... Please describe:

What is the current behavior?

The documentation suggests to setup a separate ClientKafka, which does not share the same connection as ServerKafka.

Issue Number: N/A

What is the new behavior?

Update documentation to use KafkaContext to get the active consumer and commit offsets with it.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@kamilmysliwiec kamilmysliwiec merged commit 6500880 into nestjs:master Jul 5, 2024
@kamilmysliwiec
Copy link
Member

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants