Skip to content

Conversation

@Berger92
Copy link
Contributor

@Berger92 Berger92 commented May 28, 2020

Missing protocol throws an error in the ES client. Also, the ConfigService doesn't have getString() method. It might be get() or just get().

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x ] Other... Please describe: Issues with docs

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x ] No

Other information

Missing protocol throws an error in the ES client. Also, the ConfigService doesn't have getString() method. It might be get<string>() or just get().
@kamilmysliwiec kamilmysliwiec merged commit 82b054c into nestjs:master May 29, 2020
@kamilmysliwiec
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants