-
Notifications
You must be signed in to change notification settings - Fork 419
Description
Is there an existing issue that is already proposing this?
- I have searched the existing issues
Is your feature request related to a problem? Please describe it
I cannot select another websocket implementation for subscriptions, and nest doesn't respect the selected websocket implementation from the adapter settings.
Describe the solution you'd like
I was looking at this file https://github.com/nestjs/graphql/blob/master/packages/graphql/lib/services/gql-subscription.service.ts to see what websocket implementation would be used when enabling graphql-ws - it looks like it defaults to using the "ws" implementation from node (/lib/use/ws).
It would be awesome if we could select which implementation was used, either through the registered adapter in Nest JS or just the ones that are provided by the author of Graphql-ws here: https://github.com/enisdenjo/graphql-ws/tree/master/src/use - which would allow selection of fastify, uWebsockets, or the default node implementation.
Teachability, documentation, adoption, migration strategy
No response
What is the motivation / use case for changing the behavior?
The node WS implementation is not as performant in my testing as these other libraries. Seems like it might require very little configuration changes to actually swap this library to another from his supported implementations?
Thank you for providing this library, Nest is like a dream come true :)