perf(graphql): cache internal core module lookup#3821
Merged
kamilmysliwiec merged 1 commit intonestjs:masterfrom Feb 4, 2026
Merged
Conversation
Cache the InternalCoreModule reference after the first lookup to avoid iterating through all modules on every request-scoped resolver call. This reduces complexity from O(n) to O(1) for subsequent calls, providing significant performance improvements in applications with many modules. Fixes nestjs#3816
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The
registerContextProvidermethod inResolversExplorerServiceiterates through all modules on every request-scoped resolver call to findInternalCoreModule. In applications with many modules (100+), this becomes a significant performance bottleneck with O(n) complexity on every call.Issue Number: #3816
What is the new behavior?
Cache the
InternalCoreModulereference after the first lookup, reducing complexity from O(n) to O(1) for subsequent calls. Uses lazy initialization so projects without request-scoped resolvers pay no cost.Also added test coverage for
@Inject(CONTEXT)to verify REQUEST token injection works correctly.Does this PR introduce a breaking change?
Other information
Test plan:
request-scoped.spec.ts,graphql-request-scoped.spec.ts)@Inject(CONTEXT)receives proper context withreqdefined