fix: replace require('fs') with ESM import in build e2e spec#3285
Merged
kamilmysliwiec merged 2 commits intov12.0.0from Mar 11, 2026
Merged
fix: replace require('fs') with ESM import in build e2e spec#3285kamilmysliwiec merged 2 commits intov12.0.0from
require('fs') with ESM import in build e2e spec#3285kamilmysliwiec merged 2 commits intov12.0.0from
Conversation
12 tasks
Co-authored-by: kamilmysliwiec <23244943+kamilmysliwiec@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] WIP address feedback from review on v12.0.0 major release PR
fix: replace Mar 11, 2026
require('fs') with ESM import in build e2e spec
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
cleanDist()helpers inbuild.command.e2e-spec.tsusedrequire('fs')— unavailable in ESM modules — causing runtime failures since the test file runs under"type": "module".Changes
test/e2e/build.command.e2e-spec.ts: Added top-levelimport * as fs from 'fs'and removed the inlinerequire('fs')calls from bothcleanDist()functions.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.