fix(test): use mockReturnValue for synchronous fs mocks#3286
Merged
kamilmysliwiec merged 2 commits intov12.0.0from Mar 11, 2026
Merged
fix(test): use mockReturnValue for synchronous fs mocks#3286kamilmysliwiec merged 2 commits intov12.0.0from
kamilmysliwiec merged 2 commits intov12.0.0from
Conversation
12 tasks
Co-authored-by: kamilmysliwiec <23244943+kamilmysliwiec@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Address feedback from PR #3280 for v12.0.0 major release
fix(test): use mockReturnValue for synchronous fs mocks
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fs.readdirSyncandfs.readFileSyncmocks in theFileSystemReaderspec were usingmockResolvedValue, which wraps the return in a Promise. Since these are synchronous APIs, the unit under test would receive aPromiseinstead of the expectedstring/string[], masking real behavior.Change
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.