Shutdown hooks not working in NestJS when Puppeteer browser is created

[ssljivic]

Is there an existing issue for this?

• I have searched the existing issues

Current behavior

When Puppeteer is used, NestJS does not call any onModuleDestroy() methods, although app.enableShutdownHooks() has been called.

Minimum reproduction code

https://github.com/ssljivic/nest-puppeteer-bug

Steps to reproduce

Install packages:
npm i

Start the app without Pupeteer:
npm run dev
Stop the app by pressing Ctrl + C in the terminal
Observe that "OnModuleDestroy start" and "OnModuleDestroy end" are printed.

Start the app with Pupeteer:
WITH_PUPPETEER=true npm run dev
Stop the app by pressing Ctrl + C in the terminal
Observe that "OnModuleDestroy start" and "OnModuleDestroy end" have not been printed.

Expected behavior

Whether Puppeteer is used or not, onModuleDestroy() methods should be called.

Package

• I don't know. Or some 3rd-party package
• @nestjs/common
• @nestjs/core
• @nestjs/microservices
• @nestjs/platform-express
• @nestjs/platform-fastify
• @nestjs/platform-socket.io
• @nestjs/platform-ws
• @nestjs/testing
• @nestjs/websockets
• Other (see below)

Other package

No response

NestJS version

10.3.8

Packages versions

{
  "name": "nest-pup",
  "version": "1.0.0",
  "description": "",
  "private": true,
  "license": "UNLICENSED",
  "scripts": {
    "build": "nest build",
    "start": "nest start",
    "dev": "nest start --watch",
    "start:prod": "node dist/main"
  },
  "dependencies": {
    "@nestjs/common": "^10.3.8",
    "@nestjs/core": "^10.3.8",
    "@nestjs/platform-express": "^10.3.8",
    "puppeteer": "^24.6.0"
  },
  "devDependencies": {
    "@nestjs/cli": "^10.3.2",
    "@nestjs/schematics": "^10.1.1",
    "@swc/cli": "^0.3.12",
    "@swc/core": "^1.4.16",
    "@types/express": "^4.17.21"
  }
}

Node.js version

v22.12.0

In which operating systems have you tested?

• macOS
• Windows
• Linux

Other

No response

[ssljivic]

I updated the reproduction repo to use the latest NestJS version 11.0.13, and the behaviour is still the same.

[micalevisk]

I've managed to reproduce that in a simply manner:

demo.mp4

pretty weird 🤔

[micalevisk]

for reference, I tested just the puppeteer code (with NestJS CLI) and it worked as expected: the SIGINT signal was handled.

I guess this has to do with some magic wrapping around SIGINT event handlers that puppeteer makes

[ssljivic]

I do not think it has anything to do with Puppeteer.
I updated the reproduction repo so you can now test SIGINT and Puppeteer without NestJS:

Start the bare app:

npm run build && npm run bare

Press Ctrl + C and observe that the SIGINT handler has been executed.

[kamilmysliwiec]

Not sure if I'm following. How's this a NestJS issue?

[ssljivic]

Not sure if I'm following. How's this NestJS issue?

@kamilmysliwiec, for some reason, NestJS is not invoking onModuleDestroy() when Puppeteer is used.

On the other side, in the "bare" app, without NestJS, shutdown hooks are called properly, so it does not seem like a Puppeteer issue.

[kamilmysliwiec]

As soon as you move process.on("SIGINT") below the const browser = await puppeteer.launch() line in your bare.ts file, your event listener won't be called

[ssljivic]

You're absolutely right. In fact, Puppeteer already provides options to override its default SIG* behavior:

{
  handleSIGINT: false,
  handleSIGHUP: false,
  handleSIGTERM: false,
}