feat(): upload file decorator#573
Closed
rafpran wants to merge 1 commit into
Closed
Conversation
@see https://github.com/OAI/OpenAPI-Specification/blob/master/versions/3.0.2.md#mediaTypeObject According to spec multipart should be described in responseBody branch. It is possible with use of @ApiBody annotation. Code generator has been unnecesarily adding $ref to locally typed schema. resolves: nestjs#167
rafpran
added a commit
to rafpran/swagger
that referenced
this pull request
Feb 19, 2020
Skeleton for further work. See: https://github.com/OAI/OpenAPI-Specification/blob/master/versions/3.0.2.md#mediaTypeObject Requires: nestjs#573 Resolves: nestjs#167
3 tasks
|
What is the reason, pull request is not merged yet?
? |
| @ApiConsumes('multipart/form-data') | ||
| @UseInterceptors(FileInterceptor('file')) | ||
| @ApiBody({ | ||
| type: 'multipart/form-data', |
Member
There was a problem hiding this comment.
Suggested change
| type: 'multipart/form-data', |
This isn't how the @ApiBody() decorator is supposed to work
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@see https://github.com/OAI/OpenAPI-Specification/blob/master/versions/3.0.2.md#mediaTypeObject
According to spec multipart should be described in responseBody branch.
It is possible with use of @ApiBody annotation.
Code generator has been unnecesarily adding $ref to locally typed schema.
resolves: #167
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information